95608[BUGFIX] Do not map value types as Extbase relations
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+6 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Enum/AgeGroup.phpnew+26 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Person.php+24 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+18 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql+2 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Model/Example.phpnew+65 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Repository/ExampleRepository.phpnew+32 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Type/JsonValue.phpnew+48 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Configuration/TCA/tx_testjsonfields_domain_model_example.phpnew+58 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Configuration/Services.yamlnew+8 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/composer.jsonnew+23 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/Fixtures/ColumnMapFactoryEntityFixture.php+12 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/Fixtures/ColumnMapFactoryEnumFixture.phpnew+26 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/Fixtures/ColumnMapFactoryTypeFixture.phpnew+30 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/ColumnMapFactoryTest.php+62 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/NonDomainObjectPropertyPersistenceTest.phpnew+200 −0
- composer.json+1 −0
Review log 69
-
Garvin Hicking commented on patch set 1 09/03/26, 16:44
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php * typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Model/Example.php * typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Configuration/TCA/tx_testjsonfields_domain_model_example.php -
Garvin Hicking commented on patch set 2 09/03/26, 16:49
Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 09/03/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107765
-
core-ci voted on patch set 1 V -1 09/03/26, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107764
-
Stefan Bürk marked it ready for review 09/03/26, 20:27
-
Stefan Bürk uploaded patch set 3
V -109/03/26, 20:32 -
core-ci voted on patch set 3 V +1 09/03/26, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107782
-
Stefan Bürk voted on patch set 3 CR +2 V +2 09/03/26, 22:42
-
Stefan Bürk merged patch set 4 09/03/26, 22:43