Review main Merged

95616[BUGFIX] Retry email report after failed delivery

Wouter Wolters CR +2 V +2 Normal +133 −1 updated 10/01/26, 07:24

Commit message

The LinkValidator stores refreshed broken-link results before it tries
to send the report. If sending fails, the next execution sees an
unchanged result and skips the report.

Also send the report when the scheduler recorded a failure for the
previous task execution. A successful retry clears that failure
through the scheduler's normal execution handling.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Wouter Wolters uploaded patch set 1 09/03/26, 19:17

  2. core-ci voted on patch set 1 V +1 09/03/26, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107774

  3. Benni Mack commented on patch set 1 CR -1 09/11/26, 21:41

    ValidatorTaskTest.php:64

    we don't do 2 classes in one file
  4. Wouter Wolters uploaded patch set 2 CR -1 V +1 09/13/26, 09:41

  5. core-ci voted on patch set 2 V +1 09/13/26, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108446

  6. Simon Schaufelberger commented on patch set 2 CR +1 V +1 09/13/26, 10:43

    ValidatorTaskTest.php:64 Reply

    Done
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 09/30/26, 09:11

  8. Benni Mack commented on patch set 2 09/30/26, 13:24

    ValidatorTask.php:146

    we need a least a "looks ugly" line for this, because we should replace this in v16 with a DI part, and an additional method in the SchedulerTaskRepository "findRawRecordByUid"
  9. Wouter Wolters uploaded patch set 3 CR +1 V +1 09/30/26, 17:43

  10. Wouter Wolters commented on patch set 2 09/30/26, 17:47

    ValidatorTask.php:146 Reply

    Done
  11. core-ci voted on patch set 3 V +1 09/30/26, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109683

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/30/26, 20:57

  13. Benni Mack voted on patch set 3 CR +2 V +2 10/01/26, 07:24

  14. Benni Mack merged patch set 4 10/01/26, 07:24