95619[TASK] Introduce a marker for the "all languages" value
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- André Buchmann +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 34
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+1 −0
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+4 −3
- typo3/sysext/backend/Classes/Controller/Wizard/LocalizationController.php+3 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsRemoveEmptyRelations.php+2 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.php+5 −4
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+2 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+3 −3
- typo3/sysext/backend/Classes/RecordList/DownloadRecordList.php+2 −1
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+4 −3
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+3 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −1
- typo3/sysext/core/Classes/Configuration/Tca/TcaEnrichment.php+4 −2
- typo3/sysext/core/Classes/Configuration/Tca/TcaPreparation.php+2 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+2 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −1
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+3 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+2 −1
- typo3/sysext/core/Classes/Resource/Collection/CategoryBasedFileCollection.php+2 −1
Show 14 more files
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+2 −1
- typo3/sysext/core/Classes/Routing/Aspect/SiteLanguageAccessorTrait.php+2 −1
- typo3/sysext/core/Classes/Schema/LanguageMarker.php1new+44 −0
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+3 −3
- typo3/sysext/core/Classes/Site/Entity/Site.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+4 −3
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −2
- typo3/sysext/linkvalidator/Classes/QueryRestrictions/EditableRestriction.php+2 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+2 −1
- typo3/sysext/recycler/Classes/Service/RecyclerService.php+2 −1
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+2 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+3 −2
Review log 1114
-
Benni Mack uploaded patch set 1 09/03/26, 19:49
-
Benni Mack uploaded patch set 2 09/03/26, 20:00
-
core-ci voted on patch set 1 V +1 09/03/26, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107777
-
core-ci voted on patch set 2 V +1 09/03/26, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107779
-
Eric Harrer commented on patch set 2 09/25/26, 14:57
Hi @benni@typo3.org, quick update from today's Translation Handling Initiative review: We reviewed all `-1` occurrences covered by the current patch and found no false positives. In every case, `-1` semantically means **All Languages**, including cases where the value is used synthetically rather than coming directly from a record's language field. Our extended Core analysis also found additional candidates outside the current patch. I'm going through those now and will add every occurrence that also represents **All Languages**. Once those additions are in, we'll review the expanded patch together once more. We also agreed to use the same marker both for `-1` stored in a record's language field and for synthetic `-1` values used by backend logic, filters or selectors when they mean **All Languages**. We don't want to introduce separate markers for those cases in this patch. We like the idea of introducing a corresponding marker for the default language (`0`) as well. To keep this patch focused on **All Languages** and avoid expanding its scope further, we'd prefer to address that in a separate follow-up patch. -
Benni Mack commented on patch set 2 09/30/26, 06:27
Reply
sounds good. feel free to push a new patch-set over this patch. -
Eric Harrer uploaded patch set 3
V +110/02/26, 13:16 -
core-ci voted on patch set 3 V +1 10/02/26, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109942
-
Eric Harrer commented on patch set 3 10/02/26, 13:29
Patchset 3 incorporates the additional cases discussed in today's Translation Handling Initiative review: - Extended the marker usage to further clear `-1 = All Languages` occurrences in TCA, `SlugHelper` and `EditableRestriction`. - Also use the marker for the `> -1` boundary in `EditDocumentController` - Broadened the `LanguageMarker` documentation from record language fields to the agreed semantics, including synthetic backend values. - The TypeScript occurrence keeps the literal `-1`, but now documents its relation to `LanguageMarker::ALL_LANGUAGES`, a shared PHP/TypeScript solution may be a good follow-up. - Updated the commit message to reflect the broader marker scope. -
Benni Mack marked it ready for review 10/02/26, 13:34
-
André Buchmann voted on patch set 3 CR +1 V +1 10/02/26, 13:43
-
Oli Bartsch commented on patch set 3 CR +1 V +1 10/06/26, 11:29
LanguageMarker.php:43The 14.3 backport has to drop the int. -
Benni Mack voted on patch set 3 CR +2 V +2 10/06/26, 11:40
-
Benni Mack merged patch set 4 10/06/26, 11:40