95622[TASK] Improve form validation error modal UI
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Riccardo De Contardi +1
- Maike Kiebele +1
- core-ci +1 CI
Issues 2
Files 4
- Build/Sources/TypeScript/form/backend/form-editor/modals-component.ts+114 −5
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/ValidationErrors.fluid.html+32 −5
- typo3/sysext/form/Resources/Private/Language/Database.xlf+9 −3
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/modals-component.js+1 −1
Review log 1316
-
Josua Vogel uploaded patch set 1 09/04/26, 06:36
-
Josua Vogel marked it work in progress 09/04/26, 06:48
-
core-ci voted on patch set 1 V +1 09/04/26, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107804
-
Josua Vogel uploaded patch set 2
V +109/04/26, 08:06 -
Josua Vogel marked it ready for review 09/04/26, 08:07
-
core-ci voted on patch set 2 V +1 09/04/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107821
-
Georg Ringer commented on patch set 2 CR -1 09/04/26, 11:55
Nice, but can you change the following: - Modal Header is "Alert". This should be something else I guess - THe elements are not recognized as link, neither the cursor pointer nor marked as link - I suggest to rename the button label "OK" to "Close" -
Georg Ringer commented on patch set 2 CR +1 V +1 09/04/26, 12:01
stupid me, works all -
Josua Vogel updated the commit message in patch set 3
CR +1V +109/04/26, 12:03 -
core-ci voted on patch set 3 V +1 09/04/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107867
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/04/26, 12:16
-
Riccardo De Contardi commented on patch set 3 V +1 09/04/26, 13:20
tested on latest main -
Maike Kiebele voted on patch set 3 V +1 09/07/26, 13:23
-
Benni Mack voted on patch set 3 CR +1 09/15/26, 21:12
-
Georg Ringer voted on patch set 3 CR +2 V +2 09/20/26, 15:13
-
Georg Ringer merged patch set 4 09/20/26, 17:23