Review main Merged

95625[BUGFIX] Compare decoded JSON keys order-insensitive in test

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 09/04/26, 08:15

Commit message

NonDomainObjectPropertyPersistenceTest compares the decoded raw
value of a TCA type=json column with assertSame, which also
checks the key order. MySQL 8 stores native JSON columns in a
normalized binary format and returns object members sorted by
key length and key name, so the nightly mysql functional jobs
fail while sqlite, mariadb and postgres keep the insertion
order and pass in the pre-merge pipelines.

Use assertEquals for the decoded array, as the backports to
14.3 and 13.4 of the related change already do.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 09/04/26, 06:43

  2. core-ci voted on patch set 1 V +1 09/04/26, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107807

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/04/26, 07:27

  4. Stefan Bürk commented on patch set 1 CR +2 V +2 09/04/26, 08:15

    Test only, going to merge this as defacto no-brainer to get nightlies green again.
  5. Stefan Bürk merged patch set 2 09/04/26, 08:15