Review 14.3 Merged

95631[BUGFIX] Hand correlation ids to the remaining history writers

Benni Mack CR +2 V +2 Normal +139 −12 updated 09/04/26, 08:57

Commit message

Since #110586 and #110588 every history writer that belongs to a data
handler operation writes below the correlation scope of that
operation, except for three.

ExtbaseHistoryTracker passed no correlation id at all, so its entries
fell back to an id derived from the record alone, without any scope.
There is no data handler run to inherit from here, so the new
PersistenceCorrelationScope holds one scope per Extbase persistence
run: Backend starts a new one with every commit, and the tracker puts
all entries of that run below it. A run is the counterpart of one
data handler run, and scoping per run rather than per request keeps
long running processes such as messenger workers from piling up
unrelated changes below a single id.

DataHandlerInternalWorkspaceTablesHook discards all records of a
deleted workspace through a data handler of its own, and
EditDocumentController runs "save and duplicate" as a second data
handler. Both started a new random scope instead of continuing the one
they belong to, and receive the correlation id of the surrounding
operation now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Benni Mack commented on patch set 1 09/04/26, 08:32

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php
  2. Benni Mack commented on patch set 2 09/04/26, 08:33

    Published edit on patch set 1.
  3. core-ci voted on patch set 2 V +1 09/04/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107826

  4. Benni Mack marked it ready for review 09/04/26, 08:56

  5. Benni Mack voted on patch set 2 CR +2 V +2 09/04/26, 08:56

  6. Benni Mack merged patch set 3 09/04/26, 08:57