Review 14.3 Merged

95632[BUGFIX] Fix various glitches in the record history module

Benni Mack CR +2 V +2 Normal +232 −14 updated 09/04/26, 09:51

Commit message

Three unrelated defects in the "History/Undo" module.

The "Show entries" setting did not limit the changelog. setMaxSteps()
was applied inside findEventsForRecord() as a per record
setMaxResults(), and with "show sub elements" enabled getHistoryData()
calls that once for every record on the page and merges the results
afterwards, so on a page with 60 content elements "20" could produce
up to 1200 rows. The limit now applies to the merged changelog too.

A rollback was executed on a GET request without confirmation,
although it can delete records, undelete records and overwrite field
values. The rollback controls are submit buttons of a POST form now
and ask for confirmation, and rollbackFields is only read from the
request body.

Moves and stage changes showed nothing but a badge. A move stores its
payload under other keys than a modification and holds fields that are
not part of TCA, so it cannot go through renderDiff(). It is rendered
as its source and target page instead. Stage changes render their
comment, which so far was only visible in the workspaces module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 69

  1. Benni Mack commented on patch set 1 09/04/26, 08:35

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Functional/Controller/ContentElement/ElementHistoryControllerTest.php
  2. Benni Mack commented on patch set 2 09/04/26, 08:36

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/04/26, 08:36

  4. core-ci voted on patch set 2 V -1 09/04/26, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107828

  5. core-ci voted on patch set 1 V -1 09/04/26, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107827

  6. Benni Mack commented on patch set 3 V -1 09/04/26, 09:14

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 09/04/26, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107843

  8. Benni Mack voted on patch set 3 CR +2 V +2 09/04/26, 09:51

  9. Benni Mack merged patch set 4 09/04/26, 09:51