Review 14.3 Merged

95635[BUGFIX] Ensure LanguagePackCommand does not load TCA in scheduler mode

Benjamin Franzke CR +2 V +2 Easy +11 −3 updated 09/10/26, 08:09

Commit message

The `LanguagePackCommand` is registered as a failsafe command
in order to be usable when the system is not installed yet
and in order to be able to run, when the full bootstap fails.
Therefore it has to load TCA explicitly via `BootService` if
run via CLI. When this command is dispatched from the scheduler
service, the bootstrap did actually run and TCA was already loaded,
therefore an explicit load will cause a second TCA load, which may
cause issues due to double initialization.

To ensure we only load TCA if needed, from which container we are
loaded to detect if TCA loading is required.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benjamin Franzke commented on patch set 1 09/04/26, 09:05

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Command/UpdateLanguagePackCommand.php
  2. core-ci voted on patch set 1 V -1 09/04/26, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107839

  3. Benjamin Franzke uploaded patch set 2 V -1 09/10/26, 08:00

  4. core-ci voted on patch set 2 V +1 09/10/26, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108239

  5. Benjamin Franzke marked it ready for review 09/10/26, 08:09

  6. Benjamin Franzke merged patch set 3 09/10/26, 08:09