Review main Abandoned

95647[BUGFIX] Avoid path disclosure in site settings write error

Simon Schmidt CR 0 V 0 Easy +17 −1 updated 09/04/26, 13:59

Commit message

When SiteSettingsController catches a SiteConfigurationWriteException,
the exception message - which contains the relative file path - was
shown directly in the backend flash message.

The path detail is now logged via writelog (SYSTEM_ERROR) and the
user-facing message only shows the site identifier.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Simon Schmidt uploaded patch set 1 09/04/26, 13:35

  2. core-ci voted on patch set 1 V +1 09/04/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107882

  3. Benjamin Kott abandoned the change 09/04/26, 13:59

    95467: [BUGFIX] Re-throw SiteConfigurationWriteException in SiteSettingsService | https://review.typo3.org/c/Packages/TYPO3.CMS/+/95467