Review main Merged

95649[BUGFIX] Allow to modify the actions in the workspaces module

Benni Mack CR +2 V +2 Hard +328 −82 updated 09/11/26, 23:21

Commit message

The record table of the workspaces module renders a fixed set of
action buttons per record. Listeners of the PSR-14 event
AfterDataGeneratedForWorkspaceEvent can enrich the records shown
in the module, but they can neither add a button of their own nor
hide or disable one of the buttons the module renders itself, which
leaves overriding the module JavaScript as the only option.

The buttons of a record are now described in an "actions" section
that listeners can modify. It is determined after the event has
been dispatched and merged with what listeners provided, so the
permissions of a record still yield the default state, and
listeners modifying those keep working as before.

The module additionally broke for records sitting in a stage that
has been removed from the workspace: getRowDetails() allows the
stage to be unresolvable, but dereferenced it unconditionally
afterwards. Since versionIsModified() calls that method for every
record of the grid and catches RuntimeException only, one such
record took down the whole module with a TypeError.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 911

  1. Benni Mack uploaded patch set 1 09/04/26, 15:39

  2. core-ci voted on patch set 1 V +1 09/04/26, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107892

  3. Simon Schaufelberger commented on patch set 1 09/04/26, 15:58

    Important-94407-CustomActionsInTheWorkspacesModule.rst:26

    in other changelogs we write here the full event listener implementation. that would make it easier to copy/paste.
  4. Benni Mack uploaded patch set 2 V +1 09/11/26, 22:10

  5. Benni Mack commented on patch set 2 09/11/26, 22:10

    Important-94407-CustomActionsInTheWorkspacesModule.rst:26 Reply

    Done
  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/11/26, 22:12

  7. core-ci voted on patch set 2 V +1 09/11/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108356

  8. Stefan Bürk voted on patch set 2 CR +1 09/11/26, 22:27

  9. Stefan Bürk voted on patch set 2 V +1 09/11/26, 22:53

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/11/26, 23:21

  11. Benni Mack merged patch set 3 09/11/26, 23:21