Review main Ready for review Quiet

95650[TASK] More debug output for "File has been deleted." exception

Simon Schaufelberger CR -1 V 0 Easy +7 −7 updated 10/28/26, 17:35

Commit message

Output the storage and identifier as well to give a hint which file is
deleted, otherwise it is impossible to find it out.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/95650/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/95650/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Torben Hansen -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 1

Review log 34

  1. Simon Schaufelberger uploaded patch set 1 09/04/26, 15:43

  2. Simon Schaufelberger commented on patch set 1 09/04/26, 15:44

    Unresolved

    @oliver.hader@typo3.org @elias@haeussler.dev Do you see any security issue by exposing the file identifier in the exception message or not?
  3. core-ci voted on patch set 1 V +1 09/04/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107893

  4. Torben Hansen commented on patch set 1 CR -1 10/28/26, 17:35

    Please do not add any path information in exceptions, as those might be shown in FE/FE context revealing sensitive information. Add logging using Logging Framework instead.