Review main Merged

95653[TASK] Rename event to `BeforeFormValueIsRenderedEvent`

Benni Mack CR +2 V +2 Normal +127 −111 updated 09/04/26, 22:03

Commit message

The recently added `ModifyFormValueForRenderingEvent` is named after
what a listener may do with it. All other events in EXT:form are named
after the moment they are dispatched, e.g.
`BeforeRenderableIsRenderedEvent`, so the event is renamed to
`BeforeFormValueIsRenderedEvent`.

While at it, the event API is aligned with its siblings: the modifiable
`$data` array is a public property instead of getter and setter, and
the form element and the runtime are exposed as read-only properties.
The runtime is what allows a listener to scope itself to a single form
or to take the values of other form elements into account, which was
not possible before.

The event is unreleased, so no deprecation is needed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Albrecht Köhnlein +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Albrecht Köhnlein +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 67

  1. Benni Mack uploaded patch set 1 09/04/26, 16:28

  2. core-ci voted on patch set 1 V +1 09/04/26, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107900

  3. Albrecht Köhnlein commented on patch set 1 CR +1 V +1 09/04/26, 16:43

    My first idea when introducing this event was "BeforeFormValueDataIsAssignedEvent" - but I am also fine with your name.
  4. Josua Vogel voted on patch set 1 CR +1 V +1 09/04/26, 17:20

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/04/26, 21:41

  6. Georg Ringer voted on patch set 1 CR +2 V +2 09/04/26, 22:03

  7. Georg Ringer merged patch set 2 09/04/26, 22:03