Review main Merged

95654[TASK] Remove redundant sorting in ReferenceIndex

Wouter Wolters CR +2 V +2 Easy +0 −2 updated 09/07/26, 08:33

Commit message

TcaSchemaBuilder sorts the TCA alphabetically before it creates the
schema collection. Consequently, the table names returned by
TcaSchemaFactory are already sorted.

Remove the redundant second sort and its resolved TODO.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Wouter Wolters uploaded patch set 1 09/04/26, 19:20

  2. core-ci voted on patch set 1 V +1 09/04/26, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107904

  3. Oliver Klee voted on patch set 1 CR +1 09/05/26, 06:58

  4. Benni Mack updated the commit message in patch set 2 CR +1 V +1 09/07/26, 06:21

  5. Benni Mack voted on patch set 2 CR +1 V +1 09/07/26, 06:21

  6. Josua Vogel voted on patch set 2 CR +1 V +1 09/07/26, 06:24

  7. core-ci voted on patch set 2 V +1 09/07/26, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107975

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 09/07/26, 06:35

  9. Benni Mack voted on patch set 2 CR +2 V +2 09/07/26, 08:33

  10. Benni Mack merged patch set 3 09/07/26, 08:33