Review main Merged

95660[TASK] Use PHP 8.5 clone-with syntax

Wouter Wolters CR +2 V +2 Hard +104 −263 updated 09/30/26, 09:21

Commit message

TYPO3 now requires PHP 8.5, which provides clone() with property
replacement. Several immutable value objects and builders still clone an
object, assign properties, and return it in separate statements.

Replace safe clone-and-assign sequences with clone-with. Keep complex
clone paths unchanged where additional mutations or method calls are
required.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/06/26, 08:29

  2. core-ci voted on patch set 1 V +1 09/06/26, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107947

  3. Oliver Klee voted on patch set 1 CR +1 V +1 09/06/26, 14:08

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/06/26, 19:36

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 09/30/26, 09:21

  6. Garvin Hicking merged patch set 2 09/30/26, 09:21