Review main Merged Breaking

95662[!!!][TASK] Throw specific exception for invalid scheduler tasks

Wouter Wolters CR +2 V +2 Normal +90 −10 updated 09/30/26, 21:27

Commit message

SchedulerTaskRepository currently converts InvalidTaskException into a
generic UnexpectedValueException after disabling an invalid task. This
hides the existing domain-specific exception from callers.

Keep the disable behavior and throw InvalidTaskException instead.
Update Scheduler consumers, tests, and the breaking changelog.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1215

  1. Wouter Wolters uploaded patch set 1 09/06/26, 08:34

  2. core-ci voted on patch set 1 V +1 09/06/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107950

  3. Oliver Klee voted on patch set 1 CR +1 V +1 09/06/26, 14:09

  4. Simon Schaufelberger commented on patch set 1 CR -1 09/06/26, 19:31

    Breaking-110637-SchedulerRepositoryThrowsInvalidTaskException.rst:38

    please use a before and after code block to make migration clear
  5. Wouter Wolters uploaded patch set 2 CR +1 V +1 09/07/26, 18:59

  6. Oliver Klee voted on patch set 2 CR +1 V +1 09/07/26, 19:02

  7. core-ci voted on patch set 2 V +1 09/07/26, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108025

  8. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 09/30/26, 09:18

  9. core-ci voted on patch set 3 V +1 09/30/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109607

  10. Oliver Klee voted on patch set 3 CR +1 V +1 09/30/26, 10:15

  11. Georg Ringer voted on patch set 3 CR +1 V +1 09/30/26, 10:36

  12. Benni Mack commented on patch set 3 09/30/26, 12:51

    Breaking-110637-SchedulerRepositoryThrowsInvalidTaskException.rst:38 Reply

    really? for a one-liner?
  13. Simon Schaufelberger commented on patch set 3 CR +1 V +1 09/30/26, 21:01

    Breaking-110637-SchedulerRepositoryThrowsInvalidTaskException.rst:38 Reply

    Done
  14. Benni Mack voted on patch set 3 CR +2 V +2 09/30/26, 21:27

  15. Benni Mack merged patch set 4 09/30/26, 21:27