Review main Merged

95663[TASK] Protect cache backend default lifetime setter

Wouter Wolters CR +2 V +2 Easy +4 −23 updated 09/07/26, 08:00

Commit message

The default lifetime setter is exposed publicly even though cache
backend options are the supported configuration path. Its only direct
Core consumers are functional tests.

Configure the Redis backend tests through constructor options, make
the setter protected, and remove a redundant lifetime test.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Wouter Wolters uploaded patch set 1 09/06/26, 08:35

  2. core-ci voted on patch set 1 V +1 09/06/26, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107949

  3. Oliver Klee voted on patch set 1 CR +1 V +1 09/06/26, 14:09

  4. Benni Mack voted on patch set 1 CR +2 V +2 09/07/26, 08:00

  5. Benni Mack merged patch set 2 09/07/26, 08:00