Review main Merged Breaking

95664[!!!][BUGFIX] Throw specific exception for missing local files

Wouter Wolters CR +2 V +2 Normal +76 −11 updated 10/09/26, 19:27

Commit message

LocalDriver::getFileInfoByIdentifier() throws a generic
InvalidArgumentException when a requested file does not exist. This
prevents callers such as FileLinkHandler from handling missing files
through the resource exception hierarchy.

Throw FileDoesNotExistException instead and update the affected
callers and tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1315

  1. Wouter Wolters uploaded patch set 1 09/06/26, 08:37

  2. core-ci voted on patch set 1 V +1 09/06/26, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107951

  3. Oliver Klee voted on patch set 1 CR +1 V +1 09/06/26, 14:08

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/09/26, 05:15

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/09/26, 05:46

  6. Simon Schaufelberger commented on patch set 1 09/09/26, 05:48

    Should the commit message title also start with !!! Since it's breaking?
  7. Simon Schaufelberger voted on patch set 1 CR -1 09/09/26, 05:51

  8. Wouter Wolters updated the commit message in patch set 2 CR +1 V +1 09/09/26, 06:43

  9. core-ci voted on patch set 2 V +1 09/09/26, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108145

  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/09/26, 07:17

  11. Simon Schaufelberger commented on patch set 2 09/09/26, 07:17

    Reply

    Done
  12. Oliver Klee voted on patch set 2 CR +1 V +1 09/09/26, 08:48

  13. Garvin Hicking voted on patch set 2 CR +1 V +1 09/30/26, 09:16

  14. Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 19:27

  15. Benni Mack merged patch set 3 10/09/26, 19:27