Review main Merged

95668[BUGFIX] Deduplicate static TypoScript includes in template records

Wouter Wolters CR +2 V +2 Normal +76 −3 updated 11/19/26, 09:55

Commit message

Duplicate entries in sys_template.include_static_file add the same
static include repeatedly. File-based include lists already remove
duplicates.

Deduplicate each record's list after trimming whitespace, preserving
the first occurrence and the order of distinct includes. Remove the
two corresponding TODO comments.

Add functional coverage for constants and setup, both static include
positions, and uncached and cached tree builds. Document the change
in include order for lists containing duplicate entries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Wouter Wolters uploaded patch set 1 09/06/26, 10:06

  2. core-ci voted on patch set 1 V -1 09/06/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107957

  3. Wouter Wolters uploaded patch set 2 V -1 09/06/26, 10:16

  4. core-ci voted on patch set 2 V +1 09/06/26, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107959

  5. Oliver Klee voted on patch set 2 V +1 09/06/26, 14:11

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/11/26, 22:15

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 09/30/26, 09:12

    not 100% sure about impact to existing installs, so not confident enough to merge on my own
  8. Benni Mack voted on patch set 2 CR +2 V +2 11/19/26, 09:55

  9. Benni Mack merged patch set 3 11/19/26, 09:55