95671[BUGFIX] Ensure numeric site identifiers stay strings
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 910
-
Oli Bartsch uploaded patch set 1 09/07/26, 07:44
-
core-ci voted on patch set 1 V +1 09/07/26, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107980
-
Stefan Bürk voted on patch set 1 CR +1 V +1 09/07/26, 09:00
-
Oliver Klee commented on patch set 1 V +1 09/07/26, 09:27
-
Oli Bartsch commented on patch set 1 09/07/26, 09:52
SiteConfiguration.php:118ReplyI don't see why this should be "dirty". It's IMO totally correct this way to ensure possible further usages are safe, too. -
Stefan Bürk commented on patch set 1 09/07/26, 09:59
SiteConfiguration.php:118ReplyIt's directly used in the next statement (ignoring code comments) within the loop, so it's exactly at the right place. (It's used 2 times in the loop but the first one already requires it as a string). Beside that, it's the same way how it is done in getAllResolvedSiteData() for example. -
Benni Mack voted on patch set 1 CR +1 V +1 09/07/26, 10:38
-
Oliver Klee voted on patch set 1 CR +1 09/07/26, 10:50
-
Georg Ringer voted on patch set 1 CR +2 V +2 09/07/26, 18:23
-
Georg Ringer merged patch set 2 09/07/26, 19:08
SiteConfiguration.php:118