Review main Merged

95681[TASK] Add immutable with-methods to VisibilityAspect

Matthias Vogel CR +2 V +2 Normal +133 −31 updated 09/12/26, 00:21

Commit message

Recreating a VisibilityAspect to change one flag requires callers
to copy every constructor argument. Newly added options can then
be lost silently, as illustrated by #110322.

Add with-methods for the existing visibility flags to preserve
unrelated settings and provide an immutable API for adjusting an
existing VisibilityAspect.

Deprecation of constructor might happen later.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 1318

  1. Matthias Vogel uploaded patch set 1 09/07/26, 12:42

  2. core-ci voted on patch set 1 V -1 09/07/26, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108008

  3. Matthias Vogel uploaded patch set 2 V -1 09/07/26, 12:51

  4. core-ci voted on patch set 2 V +1 09/07/26, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108010

  5. Matthias Vogel marked it ready for review 09/07/26, 13:03

  6. Matthias Vogel uploaded patch set 3 V +1 09/08/26, 08:56

  7. core-ci voted on patch set 3 V +1 09/08/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108066

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 09/08/26, 09:59

    I like this; talked privately a bit, so to keep track here: We need to diecuss whether we can soft-deprecate this in the backport, have no backport, making it breaking in v15 directly or whatever. But having a more stable aspect API sounds good to me here.
  9. Benni Mack commented on patch set 3 09/09/26, 09:10

    lets use it like it is, bring the change back to v14, and handle deprecation + breaking completely separate.
  10. Benni Mack uploaded patch set 4 CR +1 V +1 09/11/26, 22:53

  11. Benni Mack uploaded patch set 5 09/11/26, 22:56

  12. Benni Mack commented on patch set 5 09/11/26, 22:58

    Reply

    no deprecation for now

    Reply

    Done
  13. Benni Mack commented on patch set 5 09/11/26, 22:58

    Reply

    Done
  14. core-ci voted on patch set 4 V +1 09/11/26, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108360

  15. core-ci voted on patch set 5 V +1 09/11/26, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108361

  16. Benni Mack voted on patch set 5 CR +1 V +1 09/11/26, 23:21

  17. Garvin Hicking voted on patch set 5 CR +2 V +2 09/12/26, 00:03

  18. Garvin Hicking merged patch set 6 09/12/26, 00:21