95681[TASK] Add immutable with-methods to VisibilityAspect
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+8 −2
- typo3/sysext/backend/Classes/Http/Application.php+7 −1
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+6 −1
- typo3/sysext/core/Classes/Console/CommandApplication.php+7 −1
- typo3/sysext/core/Classes/Context/Context.php+1 −1
- typo3/sysext/core/Classes/Context/VisibilityAspect.php+50 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Tests/Unit/Context/VisibilityAspectTest.php+28 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+9 −7
- typo3/sysext/frontend/Classes/Http/Application.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+1 −3
- typo3/sysext/install/Classes/Http/Application.php+8 −1
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php+4 −6
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+2 −6
Review log 1318
-
Matthias Vogel uploaded patch set 1 09/07/26, 12:42
-
core-ci voted on patch set 1 V -1 09/07/26, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108008
-
Matthias Vogel uploaded patch set 2
V -109/07/26, 12:51 -
core-ci voted on patch set 2 V +1 09/07/26, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108010
-
Matthias Vogel marked it ready for review 09/07/26, 13:03
-
Matthias Vogel uploaded patch set 3
V +109/08/26, 08:56 -
core-ci voted on patch set 3 V +1 09/08/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108066
-
Garvin Hicking commented on patch set 3 CR +1 V +1 09/08/26, 09:59
I like this; talked privately a bit, so to keep track here: We need to diecuss whether we can soft-deprecate this in the backport, have no backport, making it breaking in v15 directly or whatever. But having a more stable aspect API sounds good to me here. -
Benni Mack commented on patch set 3 09/09/26, 09:10
lets use it like it is, bring the change back to v14, and handle deprecation + breaking completely separate. -
Benni Mack uploaded patch set 4
CR +1V +109/11/26, 22:53 -
Benni Mack uploaded patch set 5 09/11/26, 22:56
-
Benni Mack commented on patch set 5 09/11/26, 22:58
Reply
Done -
core-ci voted on patch set 4 V +1 09/11/26, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108360
-
core-ci voted on patch set 5 V +1 09/11/26, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108361
-
Benni Mack voted on patch set 5 CR +1 V +1 09/11/26, 23:21
-
Garvin Hicking voted on patch set 5 CR +2 V +2 09/12/26, 00:03
-
Garvin Hicking merged patch set 6 09/12/26, 00:21