Review main Merged

95689[BUGFIX] Keep live uids of non-child relations in workspaces

Georg Ringer CR +2 V +2 Hard +432 −12 updated 10/09/26, 19:11

Commit message

When a record is auto-versionized in a workspace,
getVersionizedIncomingFieldArray() rewrote every incoming
relation value that has a foreign_table to the uid of the
auto-created version. That is correct for children owned by
the record, which are versionized along with it, but wrong
for "select", "group" and "category" relations pointing to
independent records: If such a record happens to be edited
in the same request, it gets a version of its own, and the
relation is bent to that version uid. Publishing then leaves
the live record pointing to a uid that no longer exists, so
the relation is silently lost.

The rewrite is now limited to "inline" and "file" relations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 17

Review log 1013

  1. Georg Ringer uploaded patch set 1 09/07/26, 19:42

  2. Georg Ringer commented on patch set 1 09/07/26, 19:50

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/07/26, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108030

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/08/26, 15:24

  5. Benni Mack voted on patch set 1 CR -1 09/08/26, 19:15

  6. Benni Mack uploaded patch set 2 CR +1 V +1 10/07/26, 21:22

  7. Benni Mack commented on patch set 2 CR +1 V +1 10/07/26, 21:22

    I added more tests to it
  8. core-ci voted on patch set 2 V +1 10/07/26, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110418

  9. Benni Mack updated the commit message in patch set 3 CR +1 V +1 10/08/26, 06:04

  10. core-ci voted on patch set 3 V +1 10/08/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110445

  11. Benni Mack voted on patch set 3 CR +1 V +1 10/09/26, 19:08

  12. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 19:11

  13. Benni Mack merged patch set 4 10/09/26, 19:11