Review main Merged

95691[BUGFIX] Apply slug postModifiers when rebuilding sub page slugs

Georg Ringer CR +2 V +2 Normal +102 −2 updated 09/23/26, 22:16

Commit message

When the slug of a page changes, EXT:redirects rebuilds the
slugs of all sub pages. It did so by string surgery only:
cut off the old parent slug, prepend the new one. The
"postModifiers" of the slug field were never called, although
every other way to a slug - DataHandler and the "recalculate"
button in the backend - runs them through SlugHelper.

Extensions that build slugs from something else than the
parent slug and the own segment therefore ended up with sub
page slugs they would never have generated themselves.

The modifier loop is moved into SlugHelper::applyPostModifiers()
and is now called by SlugService as well. Without configured
postModifiers nothing changes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 78

  1. Georg Ringer uploaded patch set 1 09/07/26, 20:14

  2. Georg Ringer commented on patch set 1 09/07/26, 20:14

    This change is ready for review.
  3. Wouter Wolters voted on patch set 1 CR +1 09/07/26, 20:19

  4. core-ci voted on patch set 1 V +1 09/07/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108037

  5. Benni Mack voted on patch set 1 CR +1 V +1 09/14/26, 08:51

  6. Jochen Roth voted on patch set 1 CR +1 V +1 09/23/26, 22:09

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/23/26, 22:16

  8. Benni Mack merged patch set 2 09/23/26, 22:16