Review main Merged

95693[BUGFIX] Export category relations in impexp

Georg Ringer CR +2 V +2 Normal +122 −0 updated 11/13/26, 13:46

Commit message

Records with categories were exported without their category
relations. The exporter takes the relations of a record from
ReferenceIndex::getRelations(), and that deliberately returns
nothing for the side of an MM relation carrying
"MM_opposite_field" - which every category field with a
many-to-many relationship has.

The database column of such a field holds the number of
assigned categories, not a list of uids. Without the relation
in the export, the import took that number for a uid list and
related the record to whatever happened to have that uid,
usually the category with uid 1.

Category relations are now resolved by the exporter itself.
Other relations are untouched: the opposite side of an inline
MM relation keeps its column value of 0, so its records still
survive an export and import unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Georg Ringer uploaded patch set 1 09/07/26, 20:57

  2. Georg Ringer commented on patch set 1 09/07/26, 20:58

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/07/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108039

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 09/08/26, 16:14

  5. Benni Mack commented on patch set 1 09/30/26, 13:48

    Export.php:593

    you can also use initializeForField()
  6. Georg Ringer uploaded patch set 2 CR +1 V +1 11/03/26, 20:12

  7. Georg Ringer commented on patch set 2 11/03/26, 20:13

    Export.php:593 Reply

    Done
  8. core-ci voted on patch set 2 V +1 11/03/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113223

  9. Benni Mack voted on patch set 2 CR +1 V +1 11/09/26, 20:50

  10. Josua Vogel voted on patch set 2 CR +1 V +1 11/13/26, 12:58

  11. Benni Mack voted on patch set 2 CR +2 V +2 11/13/26, 13:46

  12. Benni Mack merged patch set 3 11/13/26, 13:46