Review 14.3 Merged

95695[BUGFIX] Keep booted container in database analyzer

Stefan Bürk CR +2 V +2 Hard +277 −5 updated 09/08/26, 07:11

Commit message

The two database analyzer actions of the install tool boot the
full container through LateBootService but rely on its default
of resetting the global container to the failsafe one before the
returned container is used. Services taken from the returned
container work, but everything resolved through
GeneralUtility::makeInstance() further down the call chain is
resolved against the failsafe container again.

Since #106867 the query restrictions fetch TcaSchemaFactory via
GeneralUtility::makeInstance(). Counting the rows of a table that
is no longer defined by any ext_tables.sql, shown as "Rows in
table" next to the rename suggestion, creates a QueryBuilder with
the DefaultRestrictionContainer while the failsafe container is
active. It does not provide TcaSchemaFactory, so v14 ends up with
an ArgumentCountError as soon as a leftover table exists.

Both actions now keep the booted container active, as every other
action of MaintenanceController already does. Main is not affected
since #110163 resolves the schema factory through the container
of the connection, and receives the same call along with the
functional and e2e tests that cover a leftover table.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 45

  1. Stefan Bürk uploaded patch set 1 09/07/26, 21:33

  2. core-ci voted on patch set 1 V +1 09/07/26, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108043

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 09/08/26, 06:44

  4. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/08/26, 07:11

  5. Benjamin Franzke merged patch set 2 09/08/26, 07:11