Review main Merged

95696[TASK] Stabilize the install tool presets e2e test

Stefan Bürk CR +2 V +2 Easy +33 −17 updated 09/14/26, 09:45

Commit message

The install tool e2e spec is one serial block with two retries,
so a single failing test repeats the whole block from its first
test, against the same instance and the same database.

"configuration presets works" switched the cache preset and
stopped on "File". An instance is set up with the database
backed caches, which own cache_hash, cache_pages and
cache_rootline together with their tag tables, and switching
the preset away never drops them. Those six tables are no
longer part of the expected schema afterwards, so the earlier
test "analyze database structure works" finds them as unused
tables and fails on every retry. That skips the rest of the
block and hides the failure which caused the retry in the
first place.

The test now ends on the "Database" preset again. Activating a
preset neither renders the form again nor waits for the request
to be answered, so each activation waits for the modal buttons
the module disables meanwhile, and the preset that was written
is asserted on a form rendered afterwards.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 09/07/26, 22:53

  2. core-ci voted on patch set 1 V +1 09/07/26, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108044

  3. Oliver Klee voted on patch set 1 V +1 09/08/26, 07:19

  4. Stefan Bürk rebased onto patch set 2 V +1 09/08/26, 09:51

  5. core-ci voted on patch set 2 V +1 09/08/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108080

  6. Oliver Klee voted on patch set 2 V +1 09/08/26, 10:15

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/08/26, 15:22

  8. Benni Mack voted on patch set 2 CR +1 V +1 09/14/26, 09:36

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 09/14/26, 09:44

  10. Stefan Bürk merged patch set 3 09/14/26, 09:45