Review main Merged

95698[TASK] Fix CGL violation in ProcessedFileTest

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/08/26, 01:43

Commit message

The coding guidelines suite fails on main since change 95074
was merged: the request object in ProcessedFileTest wraps the
constructor call in parentheses before chaining, which the
"new_expression_parentheses" rule enabled with #110417 no
longer allows.

That change was written before the rule was enabled and has
possibly not been rebased since, so neither its own review
build nor the pre-merge build had the rule in the fixer
configuration they ran against. The nightly build inspects
the whole code base and reported it with the first run after
the merge.

Fixed by running:

  ./Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 1

Review log 34

  1. Stefan Bürk uploaded patch set 1 09/08/26, 01:26

  2. core-ci voted on patch set 1 V +1 09/08/26, 01:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108048

  3. Stefan Bürk commented on patch set 1 CR +2 V +2 09/08/26, 01:43

    Merging cgl only issue in a non-production code (test file) to get nightly green.
  4. Stefan Bürk merged patch set 2 09/08/26, 01:43