Review main Merged

95713[BUGFIX] Use exact cookie parameters for cookie removal

Benjamin Franzke CR +2 V +2 Normal +130 −5 updated 09/15/26, 06:52

Commit message

Ensure cookies are actually removed by using exact cookie
parameters, as used when creating the respective cookie.

That means we need to delete the cookie with the
same domain, path, samesite and secure parameters,
as we use for cookie creation.

Since we do perform strict removal right now, we also
need to make sure to avoid sending a cookie deletion,
if a cookie was omitted due to SameSite=strict, e.g.
when the request was triggered by a cross-site request.
Therefore we do only send backend deletion cookies,
if there was a cookie sent with the request.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1318

  1. Benjamin Franzke uploaded patch set 1 09/08/26, 06:18

  2. core-ci voted on patch set 1 V +1 09/08/26, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108062

  3. Benjamin Franzke uploaded patch set 2 V +1 09/08/26, 19:06

  4. core-ci voted on patch set 2 V +1 09/08/26, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108112

  5. Benjamin Franzke rebased onto patch set 3 V +1 09/09/26, 11:42

  6. core-ci voted on patch set 3 V +1 09/09/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108161

  7. Wouter Wolters updated the commit message in patch set 4 V +1 09/11/26, 18:17

  8. Wouter Wolters voted on patch set 4 CR +1 09/11/26, 18:17

  9. core-ci voted on patch set 4 V +1 09/11/26, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108313

  10. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/12/26, 23:08

  11. Benjamin Franzke commented on patch set 4 CR -1 09/14/26, 07:41

    Thanks for the review… Still, -1 for now, we may decide to also include in 13.4, since this is required for compliance tests in some scenarios (the issue mentions PCI DSS) Also we will try to add tests
  12. Benjamin Franzke uploaded patch set 5 CR +1 V +1 09/14/26, 09:48

  13. core-ci voted on patch set 5 V +1 09/14/26, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108507

  14. Benjamin Franzke commented on patch set 5 09/14/26, 10:07

    Reply

    Done

    backend-login.spec.ts:61

    Please note that this assertion will not fail without this test with a regular test run, as our test runner uses `http://` instead of https and the bug mainly exists due to `strict` mismatch. This can be confirmed against a local https TYPO3 instance though. Example is here: ``` PLAYWRIGHT_BASE_URL=https://my.site.local/typo3/ \ ACCESSIBILITY_BACKEND_ADMIN_USERNAME=testadmin \ ACCESSIBILITY_BACKEND_ADMIN_PASSWORD="TestAdminPassword" \ npm run playwright:run -- --project e2e -g "admin can log in and out again" ``` I still decided to ship this test because * It is correct, nonetheless * It will help to avoid similar bugs once we can enable HTTPS in testing
  15. Benjamin Kott voted on patch set 5 CR +1 V +1 09/14/26, 15:51

  16. Georg Ringer voted on patch set 5 CR +1 V +1 09/14/26, 15:58

  17. Benjamin Franzke voted on patch set 5 CR +2 V +2 09/15/26, 06:40

  18. Benjamin Franzke merged patch set 6 09/15/26, 06:52