Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95729[!!!][TASK] Throw exception if YAML file does not exist
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/95729/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/95729/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php2+46 −16
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110656-YamlFileLoaderThrowsExceptionForMissingFiles.rstnew+55 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/LoadWithAnImportOfANotLoadedExtension.yamlnew+6 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/LoadWithANotExistingImport.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php+65 −12
Review log 2329
Show 34 earlier messages
-
Simon Schaufelberger uploaded patch set 1 09/08/26, 14:22
-
core-ci voted on patch set 1 V -1 09/08/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108099
-
Simon Schaufelberger uploaded patch set 2
V -109/08/26, 14:42 -
Oliver Klee updated the commit message in patch set 3 09/08/26, 14:48
-
core-ci voted on patch set 2 V +1 09/08/26, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108100
-
core-ci voted on patch set 3 V +1 09/08/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108101
-
Josua Vogel uploaded patch set 4
V +109/24/26, 14:26 -
Josua Vogel voted on patch set 4 CR +1 V +1 09/24/26, 14:26
-
Simon Schaufelberger commented on patch set 4 V -1 09/24/26, 14:32
-
core-ci voted on patch set 4 V -1 09/24/26, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109166
-
Josua Vogel uploaded patch set 5
CR +1V +109/24/26, 14:37 -
core-ci voted on patch set 5 V +1 09/24/26, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109167
-
Josua Vogel commented on patch set 5 09/24/26, 14:51
YamlFileLoader.php:124ReplyDone -
Josua Vogel voted on patch set 5 CR +1 V +1 09/24/26, 14:51
-
Benni Mack commented on patch set 5 09/24/26, 14:56
how can I reproduce this? Since we're touching EXT:core this might have implications to other places where we use yaml (site sets etc) -
Stefan Bürk commented on patch set 5 09/24/26, 15:01
Reply
Beside that - yaml linting should pick that up and part of an upgrade strategy/pipeline anyway - or not ? https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Feature-104973-ActivateLintYamlExecutableForTYPO3.html -
Simon Schaufelberger commented on patch set 5 09/24/26, 16:34
Reply
in your custom form configuration import a yaml file that doesn't exist. here is my config: `packages/my_extension/Configuration/Form/MySet/config.yaml` ``` name: vendor/base-form-set label: 'My Form Set' priority: 100 imports: - { resource: './doesnotexist.yaml' } ``` -
Simon Schaufelberger commented on patch set 5 09/24/26, 16:36
Reply
also import an existing yaml and inside that (nested) require a nonexisting yaml. -
Simon Schaufelberger commented on patch set 5 09/24/26, 22:38
Reply
@stefan@buerk.tech no, that command does not find invalid imports. -
Josua Vogel commented on patch set 5 10/07/26, 20:27
Reply
@benni@typo3.org , @stefan@buerk.tech how to proceed? -
Anton Danilov commented on patch set 5 CR -1 10/08/26, 14:14
This patch reverses the fix for #88993. That change deliberately made a failing YAML import non-fatal. EXT:form shows the impact: with `rte_ckeditor` not installed, rendering a form with a non-empty RTE-enabled field (e.g. a Confirmation finisher message) now throws, where it previously worked. The test edits add the missing dependency to the test instance and thereby hide the regression. Independently, the behaviour change is user-facing and needs a changelog entry. -
Simon Schaufelberger commented on patch set 5 10/25/26, 15:34
Reply
I had big trouble debugging what is wrong with my yaml configs because nothing was working because i moved files around and then got no error message or exception. I was totally glueless what could be the reason until i had to use xdebug and step through the whole rendering of the yaml files until i found out that the path to one file was wrong. This sucks! If paths are wrong, TYPO3 should tell me. It also does so in TypoScript! -
Oliver Klee voted on patch set 5 V +1 10/25/26, 16:07
-
Josua Vogel commented on patch set 5 CR 0 V 0 10/26/26, 14:26
Reply
Both can be met if the loader distinguishes why a file is missing: * File is missing in a loaded extension or at a relative/absolute path: throw, as in this patch. This covers moved files, typos in the path and nested imports. * Import is EXT:<key>/... and <key> is not loaded: keep the #88993 behaviour, i.e. skip the import and log it (as warning, with a hint that the extension is not loaded). What do you think? -
Simon Schaufelberger commented on patch set 5 10/26/26, 14:42
Reply
that sounds like a good idea! -
Josua Vogel uploaded patch set 6
CR -1V +110/29/26, 07:05 -
Josua Vogel commented on patch set 6 10/29/26, 07:07
Reply
Patch set 6 keeps the #88993 behaviour: if an import references an extension that is not loaded (e.g. EXT:rte_ckeditor/... without rte_ckeditor installed), the import is skipped and a warning is logged. All other errors (missing file, syntax error, path outside the project) now throw an exception. I removed rte_ckeditor from the form functional tests again. I added a Breaking changelog entry. -
Josua Vogel commented on patch set 6 10/29/26, 07:08
Reply
Resolving for now. Let´s discuss the new approach. -
core-ci voted on patch set 6 V +1 10/29/26, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112781
YamlFileLoader.php:124