Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95737[BUGFIX] Allow dots in site identifiers
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/95737/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/95737/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php+3 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+5 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+36 −0
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+25 −0
Review log 810
-
Georg Ringer uploaded patch set 1 09/08/26, 20:44
-
Georg Ringer commented on patch set 1 09/08/26, 20:44
This change is ready for review. -
core-ci voted on patch set 1 V +1 09/08/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108119
-
Wouter Wolters voted on patch set 1 CR +1 09/08/26, 21:04
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/09/26, 05:54
-
Josef Glatz voted on patch set 1 CR +1 V +1 09/09/26, 06:31
-
Benjamin Franzke commented on patch set 1 CR -1 09/09/26, 06:34
PackageDependentCacheIdentifier.php:81The prefix is meant to be a static prefix, dynamic stuff is to be hashed via `withAdditionalHashedIdentifier()`. Let's avoid introducing expensive regex operations in cache key generation, as this is meant to be fast in general. Please adapt this in `typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php` if it *really* needs to use a dynamic prefix. -
Georg Ringer uploaded patch set 2
CR +1V +109/09/26, 14:28 -
core-ci voted on patch set 2 V +1 09/09/26, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108194
-
Georg Ringer commented on patch set 2 11/03/26, 20:00
PackageDependentCacheIdentifier.php:81ReplyDone