95738[BUGFIX] Use correct label in Reports module and add missing one
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1315
-
Simon Schaufelberger uploaded patch set 1 09/08/26, 21:18
-
Simon Schaufelberger uploaded patch set 2 09/08/26, 21:22
-
core-ci voted on patch set 2 V +1 09/08/26, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108123
-
Oliver Klee voted on patch set 2 CR +1 09/10/26, 08:23
-
Benni Mack commented on patch set 3
CR +1V +109/10/26, 08:34Published edit on patch set 2. -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/10/26, 08:41
-
Simon Schaufelberger commented on patch set 3 09/10/26, 08:45
ContentStatisticsController.php:50@benni@typo3.org that cast is not consistent with the other controllers in the same dir. what about the others? -
Oliver Klee voted on patch set 3 CR +1 09/10/26, 08:46
-
core-ci voted on patch set 3 V +1 09/10/26, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108241
-
Benni Mack commented on patch set 3 09/10/26, 08:53
ContentStatisticsController.php:50ReplyI think we should fix them when we touch them (= not within this change). However, translate can null (which is the beauty of this method compared to sL), thus IMHO we should cast it to string, as setTitle() requires strings. -
Simon Schaufelberger commented on patch set 3 09/10/26, 08:55
ContentStatisticsController.php:50Replydoes that mean that if i change my backend language and the string is not translated in that language, that i will get an exception? -
Benni Mack commented on patch set 3 09/10/26, 08:57
ContentStatisticsController.php:50ReplyI think all non-translated labels fall back to english right now in the backend, so you're safe for the time being. -
Simon Schaufelberger commented on patch set 3 09/10/26, 09:04
ContentStatisticsController.php:50Replyok -
Benni Mack voted on patch set 3 CR +2 V +2 09/10/26, 09:15
-
Benni Mack merged patch set 4 09/10/26, 09:29