Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

95741[BUGFIX] Offer localization only where it is permitted

Benjamin Kott CR 0 V 0 Hard +586 −51 updated 11/11/26, 09:15

Commit message

The localization wizard and the actions that open it decided by
different rules. A record list and the record edit form asked for the
"tables_modify" permission of the table, the file list for that of
sys_file_metadata, while the wizard additionally evaluated the root
level restriction of the table. A record on the root level of a table
that keeps that restriction was therefore offered a translate button
which the wizard then refused.

The refusal was not recognizable as one: every denied endpoint answered
403 with an empty body, so the wizard rendered the generic "failed to
load" message of its step, indistinguishable from "nothing available".
A request naming a target language the user may not write passed all
steps until DataHandler refused it in its own words.

LocalizationAccess now answers all three questions - the page a record
lives on, the table, and the target language - and both sides ask it:
everything offering the wizard as an action, so nothing is offered that
would be refused, and the wizard itself, because permissions can change
while a list is open. A denied endpoint names the permission that is
missing, and the wizard renders that message instead of running its
steps.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/95741/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/95741/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Files 14

Review log 5

  1. Benjamin Kott uploaded patch set 1 09/09/26, 06:18

  2. Benjamin Kott uploaded patch set 2 09/10/26, 11:41

  3. Benjamin Kott rebased onto patch set 3 09/10/26, 11:42

  4. Benjamin Kott wrote 11/11/26, 09:15

    Unset private
  5. Benjamin Kott marked it work in progress 11/11/26, 09:15