Review main Merged

95747[TASK] Reduce password hashing in unit tests

Wouter Wolters CR +2 V +2 Normal +70 −44 updated 09/22/26, 19:54

Commit message

Several unit tests perform production-cost Argon2 operations although
they only verify how callers use the configured password hasher.

Mock the hasher in AuthenticationService, DataHandler and
SaveToDatabaseFinisher tests. Keep one production-cost hash generation
for each Argon2 implementation and use low-cost or fixed hashes for
independent verification and rehash checks.

This reduces the measured runtime of the affected tests from 7.28
seconds to 0.35 seconds while retaining their behavioral coverage.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Wouter Wolters uploaded patch set 1 09/09/26, 17:31

  2. core-ci voted on patch set 1 V +1 09/09/26, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108208

  3. Oliver Klee commented on patch set 1 V +1 09/09/26, 18:24

    Should we backport this to 14.3 as well?
  4. Wouter Wolters updated the commit message in patch set 2 V +1 09/09/26, 18:26

  5. core-ci voted on patch set 2 V +1 09/09/26, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108211

  6. Oliver Klee voted on patch set 2 V +1 09/09/26, 19:19

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/10/26, 07:20

  8. Georg Ringer voted on patch set 2 CR +1 V +1 09/10/26, 07:27

  9. Georg Ringer voted on patch set 2 CR +2 V +2 09/22/26, 19:54

  10. Georg Ringer merged patch set 3 09/22/26, 19:54