Review main Merged

95749[BUGFIX] Clear frontend caches at upcoming midnight

Wouter Wolters CR +2 V +2 Normal +67 −5 updated 09/30/26, 14:49

Commit message

Calculate the maximum cache lifetime from the upcoming midnight instead
of rounding the configured expiry date down to midnight. This restores
daily cache expiry after the default lifetime changed to one year.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Wouter Wolters uploaded patch set 1 09/09/26, 18:03

  2. core-ci voted on patch set 1 V +1 09/09/26, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108209

  3. Garvin Hicking commented on patch set 1 CR +1 09/30/26, 09:15

    Important-110660-CacheClearAtMidnightUsesUpcomingMidnight.rst:6

    I think this may not rectify an important ReST file, I would consider it a plain bugfix...?
  4. Wouter Wolters commented on patch set 1 09/30/26, 09:26

    Important-110660-CacheClearAtMidnightUsesUpcomingMidnight.rst:6 Reply

    Agreed, will remove it soon.
  5. Wouter Wolters uploaded patch set 2 CR +1 V +1 09/30/26, 10:36

  6. core-ci voted on patch set 2 V +1 09/30/26, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109613

  7. Wouter Wolters commented on patch set 2 09/30/26, 10:45

    Important-110660-CacheClearAtMidnightUsesUpcomingMidnight.rst:6 Reply

    Done
  8. Garvin Hicking commented on patch set 2 CR +1 V +1 09/30/26, 10:45

    Important-110660-CacheClearAtMidnightUsesUpcomingMidnight.rst:6 Reply

    Done
  9. Benni Mack voted on patch set 2 CR +2 V +2 09/30/26, 14:49

  10. Benni Mack merged patch set 3 09/30/26, 14:49