Review main Merged

95754[TASK] Use a contract for the extension catalogue

Benni Mack CR +2 V +2 Normal +117 −11 updated 09/11/26, 20:26

Commit message

The "Get Extensions" module read the catalogue of installable
extensions straight from ExtensionRepository, the class that queries
the local mirror of the TER index in the database. The list views
therefore depended not only on what the catalogue offers, but on where
it is stored.

ExtensionCatalogueInterface now describes what those views actually
read: one page of the list, one page of a search, the versions of a
single extension, and the distributions. ExtensionRepository implements
it and is aliased to it, so nothing changes at runtime.

Resolving a specific package for download is deliberately left out of
the contract. It is a separate concern with separate callers -
DownloadController, DistributionController, ListUtility and
DependencyUtility ask for a package by identifier or by version range
and never browse - and serving both from one interface would force
every implementation to answer both kinds of question.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Benni Mack uploaded patch set 1 09/10/26, 06:35

  2. core-ci voted on patch set 1 V +1 09/10/26, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108234

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/11/26, 10:30

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 09/11/26, 18:15

  5. Georg Ringer voted on patch set 1 CR +2 V +2 09/11/26, 20:10

  6. Georg Ringer merged patch set 2 09/11/26, 20:26