Review main Merged

95759[BUGFIX] Respect template overrides in modules without page id

Georg Ringer CR +2 V +2 Easy +24 −6 updated 10/02/26, 14:27

Commit message

Modules like the file list use the "id" argument for something
else than a page uid, e.g. a combined folder identifier. In this
case, BackendViewFactory skipped the TSconfig calculation
completely, so template overrides defined in global page TSconfig
or user TSconfig were ignored.

The global page TSconfig of pid 0, including user TSconfig
overrides, is now used as fallback, as documented for the
template override feature.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Georg Ringer uploaded patch set 1 09/10/26, 11:44

  2. Georg Ringer commented on patch set 1 09/10/26, 11:44

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/10/26, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108254

  4. Thomas Löffler commented on patch set 1 09/10/26, 13:44

    BackendViewFactory.php:75

    You can adjust or even remove the @todo here.
  5. Thomas Löffler voted on patch set 1 CR +1 V +1 09/10/26, 14:55

  6. Georg Ringer uploaded patch set 2 CR +1 V +1 10/02/26, 07:20

  7. core-ci voted on patch set 2 V +1 10/02/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109881

  8. Benni Mack commented on patch set 2 CR +1 V +1 10/02/26, 10:58

    BackendViewFactory.php:75 Reply

    Done
  9. Garvin Hicking voted on patch set 2 CR +1 V +1 10/02/26, 12:03

  10. Benni Mack voted on patch set 2 CR +2 V +2 10/02/26, 14:27

  11. Benni Mack merged patch set 3 10/02/26, 14:27