Review 14.3 Merged

95761[BUGFIX] Always exclude app package from active packages

Helmut Hummel CR +2 V +2 Normal +135 −6 updated 09/21/26, 10:40

Commit message

The VirtualAppPackage represents the project root package and must not
be treated like an active TYPO3 package. In particular, configuration
resources such as TCA or database schema definitions must not be
evaluated for it.

Previously, the app package could explicitly be included in
PackageManager::getActivePackages(). This was only used during the
initial setup and web-based setup, while other code paths such as
extension:setup already ignored it. As a result, configuration
resources from the project root package were handled inconsistently.

Remove the option to include the VirtualAppPackage in the list of
active packages and always exclude it.

Public resources of the project root package are still published
explicitly during setup, which is currently the only intended
resource to be handled by the VirtualAppPackage.

This may technically be breaking for installations relying on
configuration resources from the project root package during setup.
Such resources were never handled consistently, however, and were for
example not evaluated during regular deployment, so relying on this
behavior was not supported.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Helmut Hummel uploaded patch set 1 09/10/26, 12:26

  2. core-ci voted on patch set 1 V -1 09/10/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108259

  3. Helmut Hummel uploaded patch set 2 V -1 09/11/26, 09:58

  4. core-ci voted on patch set 2 V -1 09/11/26, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108292

  5. Benjamin Franzke uploaded patch set 3 V -1 09/14/26, 10:30

  6. Benjamin Franzke voted on patch set 3 CR +1 V +1 09/14/26, 10:31

  7. core-ci voted on patch set 3 V +1 09/14/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108515

  8. Helmut Hummel voted on patch set 3 CR +2 V +2 09/21/26, 10:40

  9. Helmut Hummel merged patch set 4 09/21/26, 10:40