Review 14.3 Merged

95763[TASK] Reduce password hashing in unit tests

Wouter Wolters CR +2 V +2 Normal +72 −44 updated 09/22/26, 19:54

Commit message

Several unit tests perform production-cost Argon2 operations although
they only verify how callers use the configured password hasher.

Mock the hasher in AuthenticationService, DataHandler and
SaveToDatabaseFinisher tests. Keep one production-cost hash generation
for each Argon2 implementation and use low-cost or fixed hashes for
independent verification and rehash checks.

This reduces the measured runtime of the affected tests from 7.28
seconds to 0.35 seconds while retaining their behavioral coverage.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/10/26, 15:30

  2. core-ci voted on patch set 1 V +1 09/10/26, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108269

  3. Markus Klein voted on patch set 1 CR +1 V +1 09/11/26, 12:02

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/22/26, 17:39

  5. Georg Ringer voted on patch set 1 CR +2 V +2 09/22/26, 19:54

  6. Georg Ringer merged patch set 2 09/22/26, 19:54