Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale

95764[BUGFIX] Detect URLs in plain text consistently

Georg Ringer CR 0 V -1 Hard +249 −7 updated 09/10/26, 22:01

Commit message

Plain text URLs are detected twice: parseFunc.makelinks turns them
into links in the frontend, and the url soft reference parser records
them in the reference index, which is what linkvalidator checks.

Both used different rules. "(https://example.org/foo)" was not linked
in the frontend at all, while the reference index stored it including
the closing bracket, so linkvalidator reported that link as broken.
A link like https://example.org/TYPO3_(CMS) in turn lost its last
bracket in the frontend.

Both now strip trailing punctuation, keep brackets which have been
opened within the URL itself, and the frontend also links URLs which
directly follow an opening bracket.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/95764/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/95764/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 5

Review log 12

  1. Georg Ringer uploaded patch set 1 09/10/26, 21:54

  2. core-ci voted on patch set 1 V -1 09/10/26, 22:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108272