Review main Merged

95769[BUGFIX] Label the "Navigation title" column in "Sort sub pages"

Amir Arends CR +2 V +2 Easy +1 −1 updated 09/14/26, 07:29

Commit message

The "Sort sub pages" view asks for the label key "fieldNavTitle", while locallang_pages_sort.xlf defines that unit as "fieldNavitle".
The key does not resolve, f:translate returns an empty string and the column header stays blank -- it never had a label since the column was added in #84932.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Windloff +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Windloff +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Amir Arends uploaded patch set 1 09/11/26, 15:03

  2. core-ci voted on patch set 1 V +1 09/11/26, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108304

  3. Amir Arends uploaded patch set 2 V +1 09/11/26, 15:14

  4. Amir Arends updated the commit message in patch set 3 09/11/26, 15:15

  5. core-ci voted on patch set 2 V -1 09/11/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108306

  6. core-ci voted on patch set 3 V +1 09/11/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108307

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 09/11/26, 18:12

  8. Daniel Windloff voted on patch set 3 CR +1 V +1 09/13/26, 15:14

  9. Benni Mack voted on patch set 3 CR +2 V +2 09/14/26, 07:12

  10. Benni Mack merged patch set 4 09/14/26, 07:29