Review main Merged

95773[BUGFIX] Group records using translation domain package

Wouter Wolters CR +2 V +2 Normal +94 −11 updated 09/30/26, 09:06

Commit message

Use the package part of translation domain references when the extension
cannot be inferred from the table name. An explicit ctrl.groupName takes
precedence over the package referenced by the record title.

This restores the extension title and icon in the new record wizard.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anton Danilov +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anton Danilov +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 810

  1. Wouter Wolters uploaded patch set 1 09/11/26, 18:07

  2. core-ci voted on patch set 1 V +1 09/11/26, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108312

  3. Anton Danilov commented on patch set 1 09/14/26, 15:50

    The reported case (no `ctrl.groupName`, translation-domain `ctrl.title`) works with this. One thing to flag about `ctrl.groupName`: the change makes a translation-domain `title` take precedence over an explicitly configured `groupName` for the group's title/icon. That isn't new - the legacy `LLL:EXT:` path already behaves this way (a `tx_` table with `groupName` + an `LLL:EXT:` title gets the title's extension). So the patch is consistent, but an explicit `groupName` is effectively ignored whenever the title resolves to an extension. Example: ```php 'ctrl' =[ 'title' ='LLL:EXT:my_ext/Resources/Private/Language/locallang.xlf:my_table', // or the translation-domain variant: 'my_ext.db:my_table' 'groupName' ='styleguide', ], ``` Expected per the https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Ctrl/Index.html#confval-ctrl-groupname ("set its `groupName` to the key of another extension, the table will appear in the list of records from that other extension"): styleguide's title/icon. Actual: `my_ext`'s, because `$_EXTKEY` is resolved from the title before `groupName` is consulted. If the intent is that an explicit `groupName` win, deriving the extension from the title should only happen when no `groupName` is set, e.g.: ```php if ($configuredGroupName === '') { // LLL:EXT: / translation-domain extraction } elseif (ExtensionManagementUtility::isLoaded($configuredGroupName)) { $_EXTKEY = $configuredGroupName; } ``` This would fix it for both syntaxes and make predefined-group handling deterministic. Not scoring - just flagging.
  4. Wouter Wolters uploaded patch set 2 V +1 09/26/26, 15:12

  5. Wouter Wolters commented on patch set 2 09/26/26, 15:13

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/26/26, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109341

  7. Oliver Klee voted on patch set 2 V +1 09/26/26, 19:10

  8. Anton Danilov voted on patch set 2 CR +1 V +1 09/28/26, 08:57

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 09/30/26, 08:54

  10. Garvin Hicking merged patch set 3 09/30/26, 09:06