Review main Merged

95774[BUGFIX] Use enum value for sortDirection in file list

Amir Arends CR +2 V +2 Easy +1 −1 updated 09/15/26, 05:49

Commit message

Switching the sort field therefore resets a descending list to ascending. Since sortDirection is a moduleData key, the invalid value is persisted in be_users.uc as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Amir Arends uploaded patch set 1 09/11/26, 19:39

  2. core-ci voted on patch set 1 V +1 09/11/26, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108314

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 09/11/26, 20:32

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/11/26, 22:09

  5. Benni Mack updated the commit message in patch set 2 CR +1 V +1 09/14/26, 06:47

  6. Benni Mack voted on patch set 2 CR +1 09/14/26, 06:47

  7. core-ci voted on patch set 2 V +1 09/14/26, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108485

  8. Benni Mack voted on patch set 2 V +1 09/14/26, 20:19

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/14/26, 22:00

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/15/26, 05:49

  11. Benni Mack merged patch set 3 09/15/26, 05:49