Review main Merged

95777[TASK] Keep temporary file storage offline state in the hash cache

Benni Mack CR +2 V +2 Normal +110 −11 updated 09/13/26, 17:42

Commit message

ResourceStorage::markAsTemporaryOffline() is a runtime fuse: a driver
can take a storage offline for five minutes. This state was persisted
in sys_registry as an "offline-until" timestamp that isOnline() had to
compare against time() on every call.

The fuse now lives in the "hash" cache as an entry with a lifetime of
300 seconds, so expiry is handled by the caching framework and flushing
the cache brings a tripped storage back online. The sys_file_storage
record is never touched by the temporary fuse; the state is shared
across web nodes as long as the hash cache uses a shared backend.

markAsPermanentlyOffline() keeps updating the record for now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Benni Mack uploaded patch set 1 09/11/26, 21:58

  2. Benni Mack marked it ready for review 09/11/26, 21:59

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/11/26, 22:09

  4. core-ci voted on patch set 1 V +1 09/11/26, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108323

  5. Benni Mack rebased onto patch set 2 CR +1 V +1 09/11/26, 23:05

  6. core-ci voted on patch set 2 V +1 09/11/26, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108363

  7. Benni Mack marked it ready for review 09/11/26, 23:27

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/11/26, 23:52

  9. Georg Ringer voted on patch set 2 CR +1 V +1 09/13/26, 11:54

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/13/26, 17:42

  11. Benni Mack merged patch set 3 09/13/26, 17:42