Review main Merged

95789[BUGFIX] Handle parallel processing folder creation

Georg Ringer CR +2 V +2 Normal +74 −1 updated 09/25/26, 18:52

Commit message

ResourceStorage::getProcessingFolder() checks whether the processing
folder exists and creates it afterwards. A parallel request can
create that very folder in between, so createFolder() throws an
ExistingTargetFolderException that nobody catches and the request
dies.

The exception is now caught in both branches - for the processing
folder of the storage itself and for one that points to another
storage - and the folder that is already there is used, just like
getNestedProcessingFolder() does since #96727.

Restoring the previous permission evaluation moves into a finally
block, so it happens even when creating the folder fails.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 09/12/26, 20:43

  2. Georg Ringer commented on patch set 1 09/12/26, 20:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/12/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108419

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/12/26, 22:56

  5. Wolfgang Klinger commented on patch set 1 09/25/26, 08:18

    Thanks, the two catch blocks are exactly what the issue asks for and match getNestedProcessingFolder(). The change does not merge anymore. #110687 (main, 14.3) already moved the permission restore into finally blocks in both branches, so this diff re-adds that. Please rebase; the third paragraph of the commit message can go, maybe with a "Related: #110687" line instead. For 13.4 the finally blocks are still missing, so the backport there either carries them or waits for a 13.4 backport of #110687.
  6. Oliver Klee voted on patch set 1 CR +1 V +1 09/25/26, 10:35

  7. Benni Mack uploaded patch set 2 CR +1 V +1 09/25/26, 17:56

  8. Benni Mack updated the commit message in patch set 3 09/25/26, 17:57

  9. Benni Mack commented on patch set 3 CR +1 V +1 09/25/26, 17:58

    Reply

    won't do it into 13.4, the rest is OK IMHO
  10. core-ci voted on patch set 3 V +1 09/25/26, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109286

  11. core-ci voted on patch set 2 V +1 09/25/26, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109285

  12. Garvin Hicking voted on patch set 3 CR +2 V +2 09/25/26, 18:30

  13. Oliver Klee voted on patch set 3 V +1 09/25/26, 18:35

  14. Garvin Hicking merged patch set 4 09/25/26, 18:52