Review main Merged

95790[BUGFIX] Rename the field shown in the page tree

Georg Ringer CR +2 V +2 Easy +4 −2 updated 09/15/26, 07:08

Commit message

With options.pageTree.showNavTitle enabled the page tree shows the
nav_title of a page, but renaming a node in the tree always wrote
the new value to title. Editors changed a label, saw no change and
had modified a field they did not intend to touch.

A tree item already carries nameSourceField, telling whether title
or nav_title is displayed. It is used again when the rename is sent
to the DataHandler, which restores the behaviour from before the
tree rendering was modernized in #102125.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Windloff +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Windloff +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 09/12/26, 20:53

  2. core-ci voted on patch set 1 V +1 09/12/26, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108420

  3. Georg Ringer commented on patch set 1 09/13/26, 11:58

    This change is ready for review.
  4. Daniel Windloff voted on patch set 1 CR +1 V +1 09/13/26, 13:30

  5. Garvin Hicking voted on patch set 1 CR +1 09/13/26, 19:55

  6. Benni Mack voted on patch set 1 CR +1 V +1 09/15/26, 05:49

  7. Georg Ringer voted on patch set 1 CR +2 V +2 09/15/26, 07:08

  8. Georg Ringer merged patch set 2 09/15/26, 07:08