Review main Merged

95791[TASK] Update PHPStan to v2.2.14

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 09/13/26, 12:51

Commit message

Updates the PHPStan development dependency from `^2.2.10` to
`^2.2.14`, keeping all maintained branches on the same version.

PHPStan v2.2.14 no longer reports the always false boolean state of
`$isSecondLine` in the TypoScript tokenizers, which has been added
to the v13.4 baseline along with the update to v2.2.10. It further
reports the offset assignment to an `ArrayObject` created without
initial data in `ObjectAccessTest`, which is now initialized with
its data as already done on main and v14.3.

Both only affect v13.4, which broke the nightly pipeline. The
adapted test and the regenerated PHPStan baseline are therefore
part of the v13.4 backport only, while main and v14.3 raise the
dependency alone.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.2.14
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Stefan Bürk uploaded patch set 1 09/13/26, 11:50

  2. core-ci voted on patch set 1 V +1 09/13/26, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108448

  3. Jochen Roth voted on patch set 1 CR +1 V +1 09/13/26, 12:09

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 09/13/26, 12:51

  5. Garvin Hicking merged patch set 2 09/13/26, 12:51