Review 14.3 Merged

95800[BUGFIX] Respect prepend_tname when creating MM tables

Benni Mack CR +2 V +2 Normal +110 −32 updated 09/14/26, 07:57

Commit message

A TCA "group" field with an "MM" table and "prepend_tname" set
stores the table name of every relation in the "tablenames"
column of the MM table, even when "allowed" names only a single
table.

DefaultTcaSchema did not take "prepend_tname" into account. It
created "tablenames" only for the local side of a relation using
"MM_oppositeUsage" and for a group field allowing more than one
table. Extensions relying on the automatic creation of MM tables
from TCA therefore ended up with a table without that column,
and every write of such a relation failed.

The column is now created for these fields as well. "fieldname"
is not added and the primary key stays "uid_local, uid_foreign",
because RelationHandler never writes a field name for
"prepend_tname" relations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Benni Mack commented on patch set 1 09/14/26, 06:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/14/26, 06:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108481

  3. Benni Mack commented on patch set 2 V -1 09/14/26, 07:18

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 09/14/26, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108488

  5. Benni Mack commented on patch set 3 V -1 09/14/26, 07:31

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 09/14/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108491

  7. Benni Mack voted on patch set 3 CR +2 V +2 09/14/26, 07:57

  8. Benni Mack merged patch set 4 09/14/26, 07:57