Review 13.4 Merged

95808[BUGFIX] Use exact cookie parameters for cookie removal

Benjamin Franzke CR +2 V +2 Normal +128 −5 updated 09/15/26, 06:52

Commit message

Ensure cookies are actually removed by using exact cookie
parameters, as used when creating the respective cookie.

That means we need to delete the cookie with the
same domain, path, samesite and secure parameters,
as we use for cookie creation.

Since we do perform strict removal right now, we also
need to make sure to avoid sending a cookie deletion,
if a cookie was omitted due to SameSite=strict, e.g.
when the request was triggered by a cross-site request.
Therefore we do only send backend deletion cookies,
if there was a cookie sent with the request.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benjamin Franzke uploaded patch set 1 09/14/26, 10:07

  2. core-ci voted on patch set 1 V +1 09/14/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108512

  3. Benjamin Franzke commented on patch set 1 CR +2 V +2 09/15/26, 06:52

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 09/15/26, 06:52