Review main Merged

95811[TASK] Add _assets_install to .htaccess RewriteRule

Simon Schaufelberger CR +2 V +2 Easy +1 −1 updated 09/23/26, 01:57

Commit message

The Install Tool writes files into public/_assets_install which is not
in the list of "Stop rewrite processing, if we are in any known
directory"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Simon Schaufelberger uploaded patch set 1 09/14/26, 11:39

  2. core-ci voted on patch set 1 V +1 09/14/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108521

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 09/17/26, 09:36

  4. Stefan Bürk voted on patch set 1 CR 0 V 0 09/17/26, 09:36

  5. Stefan Bürk commented on patch set 1 09/17/26, 09:37

    root-htaccess:324

    Should this not be: ```suggestion RewriteRule ^(?:fileadmin/|typo3conf/|typo3temp/|_assets/|_assets_install/) - [L] ```
  6. Simon Schaufelberger commented on patch set 2 V +1 09/17/26, 10:13

    Published edit on patch set 1.
  7. Simon Schaufelberger commented on patch set 2 09/17/26, 10:14

    root-htaccess:324 Reply

    Fix applied.
  8. core-ci voted on patch set 2 V -1 09/17/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108754

  9. Simon Schaufelberger rebased onto patch set 3 V -1 09/17/26, 20:01

  10. core-ci voted on patch set 3 V +1 09/17/26, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108765

  11. Georg Ringer voted on patch set 3 CR +1 V +1 09/17/26, 20:49

  12. Josua Vogel voted on patch set 3 CR +1 09/20/26, 09:11

  13. Benni Mack voted on patch set 3 CR +2 V +2 09/23/26, 01:57

  14. Benni Mack merged patch set 4 09/23/26, 01:57