Review main Merged

95816[FEATURE] Add a dry run option to the redirects:cleanup command

Georg Ringer CR +2 V +2 Hard +335 −17 updated 10/09/26, 17:56

Commit message

The "redirects:cleanup" command permanently deletes all
redirects matching the given constraints. There was no way
to verify upfront which redirects a set of constraints
actually covers.

The command therefore now provides a --dry-run option, as
already known from "cleanup:deletedrecords". If it is set,
no redirect is deleted. Instead, all redirects which would
have been deleted are listed.

The constraints are built once in the repository and shared
by the deletion and the preview, so both cannot drift apart.
This includes disabled, soft-deleted and expired redirects,
which the deletion has always removed.

The labels of the command are now resolved via the
"redirects.messages" translation domain.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 811

  1. Georg Ringer uploaded patch set 1 09/14/26, 16:31

  2. core-ci voted on patch set 1 V +1 09/14/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108544

  3. Georg Ringer commented on patch set 1 09/14/26, 16:48

    This change is ready for review.
  4. Benni Mack voted on patch set 1 CR +1 09/15/26, 12:39

  5. Benni Mack uploaded patch set 2 CR +1 V +1 10/09/26, 16:12

  6. core-ci voted on patch set 2 V +1 10/09/26, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110625

  7. Benni Mack uploaded patch set 3 V +1 10/09/26, 16:31

  8. core-ci voted on patch set 3 V +1 10/09/26, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110639

  9. Wouter Wolters voted on patch set 3 CR +1 V +1 10/09/26, 17:55

  10. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 17:56

  11. Benni Mack merged patch set 4 10/09/26, 17:56