Review main Abandoned

95817[FEATURE] Process system resource images without FAL

Benni Mack CR 0 V -1 Hard +645 −50 updated 09/23/26, 15:29

Commit message

Extension resources ("EXT:"/"PKG:" paths) rendered as images via the
Fluid image ViewHelpers or the TypoScript imgResource content object
previously had to be resolved through the File Abstraction Layer,
which relied on the "fallback storage" transparently mapping any
path within the public web directory to a sys_file record. Every
processed extension resource image therefore implicitly created (or
looked up) an indexed file record editors could see in the file
list, even though the file is not part of any file storage.

The new SystemResourceImageProcessor resizes, crops and converts
such images directly via GraphicalFunctions::resize(), the same way
GifBuilder does. Processed variants are written to
typo3temp/assets/images/ and are never tracked in sys_file or
sys_file_processedfile.

ImageService gained a resolveImageSource() method that resolves a
string source to either a FAL File/FileReference or a
PackageResource. The new ImageProcessor service is the single entry
point both Fluid image ViewHelpers use to process the resolved
image, delegating internally to either the regular FAL processing
chain or SystemResourceImageProcessor.

This is an alternative to Gerrit change 95814
(Change-Id I037a991efe5300e48635dd78ace53ecc3b9163c5): instead of
branching on the resolved image type at each of the two ViewHelpers,
that branching is consolidated into the ImageProcessor service.
Reviewers should compare both approaches; only one is meant to land.

This is independent of the still-existing FAL fallback storage and
does not change how paths within regular file storages are
resolved.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 15

Review log 68

  1. Benni Mack uploaded patch set 1 09/14/26, 16:34

  2. Benni Mack updated the commit message in patch set 2 09/14/26, 16:34

  3. Benni Mack commented on patch set 2 09/14/26, 16:44

    Alternative to https://review.typo3.org/c/Packages/TYPO3.CMS/+/95814 - same feature, but the FAL-vs-system-resource branching is consolidated into a single ImageProcessor service instead of being duplicated at each of the two ViewHelpers. Please compare both approaches; only one is meant to land.
  4. core-ci voted on patch set 1 V -1 09/14/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108545

  5. core-ci voted on patch set 2 V -1 09/14/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108546

  6. Benni Mack commented on patch set 2 09/14/26, 18:17

    Third alternative: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95818 - File and PackageResource are made to genuinely implement a shared capability interface (LocallyProcessableInterface, alongside the existing SystemResourceInterface), so ImageProcessor dispatches on capability instead of on a concrete-type instanceof. Please compare all three (95814, 95817, 95818); only one is meant to land.
  7. Benni Mack marked it work in progress 09/14/26, 19:57

  8. Benni Mack abandoned the change 09/23/26, 15:29