95817[FEATURE] Process system resource images without FAL
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+12 −4
- typo3/sysext/core/Classes/Imaging/ImageProcessor.phpnew+47 −0
- typo3/sysext/core/Classes/Imaging/ImageResource.php+19 −0
- typo3/sysext/core/Classes/Imaging/SystemResourceImageProcessor.phpnew+113 −0
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.php+9 −0
- typo3/sysext/core/Documentation/Changelog/14.3.x/Feature-110702-SystemResourceImageProcessing.rstnew+56 −0
- typo3/sysext/core/Tests/Functional/Imaging/SystemResourceImageProcessorTest.phpnew+74 −0
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessorTest.phpnew+55 −0
- typo3/sysext/extbase/Classes/Service/ImageService.php+29 −0
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+27 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+48 −16
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+62 −16
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+12 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+14 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+68 −3
Review log 68
-
Benni Mack uploaded patch set 1 09/14/26, 16:34
-
Benni Mack updated the commit message in patch set 2 09/14/26, 16:34
-
Benni Mack commented on patch set 2 09/14/26, 16:44
Alternative to https://review.typo3.org/c/Packages/TYPO3.CMS/+/95814 - same feature, but the FAL-vs-system-resource branching is consolidated into a single ImageProcessor service instead of being duplicated at each of the two ViewHelpers. Please compare both approaches; only one is meant to land. -
core-ci voted on patch set 1 V -1 09/14/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108545
-
core-ci voted on patch set 2 V -1 09/14/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108546
-
Benni Mack commented on patch set 2 09/14/26, 18:17
Third alternative: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95818 - File and PackageResource are made to genuinely implement a shared capability interface (LocallyProcessableInterface, alongside the existing SystemResourceInterface), so ImageProcessor dispatches on capability instead of on a concrete-type instanceof. Please compare all three (95814, 95817, 95818); only one is meant to land. -
Benni Mack marked it work in progress 09/14/26, 19:57
-
Benni Mack abandoned the change 09/23/26, 15:29
I think https://review.typo3.org/c/Packages/TYPO3.CMS/+/95956 is better